Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counters for partitions #164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

honeyAndSw
Copy link

@honeyAndSw honeyAndSw commented Dec 28, 2020

Thanks for the useful library! My team is really happy with it.
But while using this library on production, I've found counters per partition could be useful for debugging. For example, right now it’s not possible to tell which partition’s requests are being rejected so I have to compare to other metrics then guess.

Implementation:
Four status counters are added to Partition class and they get updated according to its status. rejected counter will be incremented immediately due to a different way of handling rejection, otherwise Listener will do the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant